The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
rivet-site	Ready	Preview, Comment	Jan 2, 2026 11:37pm
rivetkit-serverless	Error		Jan 2, 2026 11:37pm

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
rivet-cloud	Ignored		Jan 2, 2026 11:37pm
rivet-inspector	Ignored	Preview	Jan 2, 2026 11:37pm

• feat(dash): surface actor errors in ui #3743
• fix(dash): use ineligible icon for runners #3742
• feat(dash): show runner pool errors #3741
• chore: update engine-full sdk #3740
• feat(engine): return error for pending actors #3730
• chore(gas): add support for find_workflows #3739
• chore(docs): document abort signal #3673 👈 (View in Graphite)
• chore(rivetkit): clean up logging configuration #3672
• chore(rivetkit): RIVET_EXPOSE_ERRORS #3671
• chore(rivetkit): specialize context types for better compiler errors #3669
• fix(rivetkit): fix c.client not respecting correct origin #3668
• fix(rivetkit): allow providing no args to createRivetKit #3667
• main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

PR Review: Document Abort Signal

Overview

This PR adds documentation for the abort signal feature in Rivet Actors, covering both automatic cleanup on actor shutdown and manual cancellation of long-running operations.

Code Quality & Documentation ✅

Strengths:

• Clear, practical examples that demonstrate real-world use cases
• Good cross-referencing between the two new sections (actions.mdx ↔ lifecycle.mdx)
• Consistent with existing documentation style and patterns
• Examples follow TypeScript best practices

Suggestions for Improvement

1. Expand the Manual Cancellation Example (actions.mdx:248-280)

The current example shows chaining c.abortSignal with a custom AbortController, but it has a subtle issue:

Issue: The custom controller stored in c.vars.controller could be overwritten if multiple generate actions run concurrently, making cancel potentially abort the wrong operation.

Suggestion: Consider adding a note about this limitation or showing a more robust pattern for handling multiple concurrent operations, or add a comment explaining the single-operation assumption.

2. Add Error Handling Guidance (actions.mdx:248-280)

When an AbortSignal fires, fetch throws an AbortError. Consider showing how to handle this gracefully in the documentation.

3. Clarify Timing of c.abortSignal (lifecycle.mdx:619-641)

The documentation states the signal fires "when the actor is stopping" but doesnt clarify the exact timing:

• Does it fire before onSleep?
• Does it fire before onDestroy?
• What happens if an action is still running?

Consider adding a brief note about the lifecycle order.

4. Consider Adding a Warning

Since onSleep might not always fire (as noted in lifecycle.mdx:196), consider adding a note that c.abortSignal is more reliable for cleanup in crash scenarios.

Security Considerations ✅

No security concerns. The examples demonstrate proper signal handling without introducing vulnerabilities.

Performance Considerations ✅

The examples are efficient:

• Properly chains abort signals without creating unnecessary listeners
• Cleans up resources appropriately
• No performance anti-patterns

Test Coverage

Question: Are there existing tests for c.abortSignal behavior? Consider adding tests that verify:

• Signal fires during actor sleep
• Signal fires during actor destroy
• In-flight operations are properly cancelled
• Multiple operations handle abortion correctly

Minor Suggestions

1. Consistency: In actions.mdx:262, consider using c.abortSignal.addEventListener("abort", ...) on a separate line for readability (matching the style in lifecycle.mdx:632)

2. Link verification: Ensure the cross-reference links work correctly:

   • /docs/actors/lifecycle#actor-shutdown-abort-signal
   • /docs/actors/actions#canceling-long-running-actions

Summary

This is a solid documentation addition that fills an important gap. The examples are practical and well-written. The suggestions above would make the documentation even more robust by addressing edge cases and providing clearer guidance on error handling and concurrent operations.

Recommendation: ✅ Approve with minor suggestions

The PR is good to merge as-is, but consider the suggestions above for a future iteration to make the documentation more comprehensive.

PR Review: Document Abort Signal

Summary

This PR adds documentation for the abort signal feature in Rivet Actors, covering both automatic cleanup on actor shutdown and manual cancellation of long-running actions.

Code Quality ✅

Strengths:

• Clear, well-structured documentation with practical examples
• Good cross-referencing between related sections (actions ↔ lifecycle)
• Examples follow existing documentation patterns and conventions
• Code samples are complete and realistic

Documentation Style:

• Follows the existing mdx format consistently
• Proper use of code blocks with TypeScript syntax highlighting
• Good section organization and heading structure

Content Review

actions.mdx (lines 248-280):

• ✅ New "Canceling Long-Running Actions" section demonstrates manual abort control
• ✅ Shows how to chain custom AbortController with c.abortSignal for dual control
• ✅ Practical chat generation example is relevant and clear
• ✅ Correctly references lifecycle documentation for automatic cleanup

lifecycle.mdx (lines 619-641):

• ✅ New "Actor Shutdown Abort Signal" section explains automatic cancellation
• ✅ Clean fetch example demonstrates the primary use case
• ✅ Correctly references actions documentation for manual cancellation
• ✅ Positioned logically in the "Advanced" section

Technical Accuracy ✅

The documentation correctly describes:

• How c.abortSignal fires when actor is stopping (sleep/destroy)
• Proper integration with fetch API signal parameter
• How to chain abort signals using addEventListener
• The relationship between automatic and manual cancellation

Suggestions for Improvement

1. Clarify abort signal behavior (minor):

   • Consider adding a note about whether the abort signal fires during crashes or only graceful shutdowns
   • Similar to how onSleep docs mention "may not always be called in situations like crashes"

2. Add error handling example (optional):

   • The fetch examples could show how to handle abort errors

3. Vars type annotation (minor):

   • In the manual cancellation example, consider adding explicit type annotation for clarity

Security Considerations ✅

No security concerns. The abort signal pattern is a standard browser API used correctly.

Test Coverage

Not applicable - this is documentation only.

Conclusion

Overall Assessment: Excellent ✅

This is a well-crafted documentation addition that:

• Addresses an important feature gap
• Provides clear, practical examples
• Maintains consistency with existing docs
• Correctly cross-references related content

The suggestions above are minor enhancements and do not block merging. The PR is ready to merge as-is.

Review generated with Claude Code